From 39711d3b761b7d5a84ecb2f5ba5ec6ea4feccfff Mon Sep 17 00:00:00 2001 From: Nemo Date: Sat, 2 May 2020 18:05:31 +0530 Subject: [PATCH] improve your scripts --- update.koreader | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/update.koreader b/update.koreader index 298a400..59db4e1 100755 --- a/update.koreader +++ b/update.koreader @@ -5,11 +5,12 @@ KINDLE_MOUNT_PATH=/run/media/nemo/Kindle GITHUB_RELEASE_URL=https://api.github.com/repos/koreader/koreader/releases/latest STORAGE_DIRECTORY=/home/nemo/Setups/Kindle +JSON_PATH="/tmp/koreader.json" -curl --silent $GITHUB_RELEASE_URL > /tmp/koreader.json +curl --silent $GITHUB_RELEASE_URL > "$JSON_PATH" -DOWNLOAD_URL=$(cat /tmp/koreader.json | jq --raw-output '.assets[] |select(.name | contains("kindle-v"))|.browser_download_url') -FILE_NAME=$(cat /tmp/koreader.json | jq --raw-output '.assets[] |select(.name | contains("kindle-v"))|.name') +DOWNLOAD_URL=$(cat "$JSON_PATH" | jq --raw-output '.assets[] |select(.name | contains("kindle-v"))|.browser_download_url') +FILE_NAME=$(cat "$JSON_PATH" | jq --raw-output '.assets[] |select(.name | contains("kindle-v"))|.name') echo "Latest version is $FILE_NAME" @@ -23,3 +24,5 @@ if [[ -d "$KINDLE_MOUNT_PATH" ]]; then echo "Kindle is mounted, pass --please to actually upgrade" fi fi + +rm -f "$JSON_PATH"